netdev - Re: [PATCH 1/2] net: Disable LRO on devices that are forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87prqc9ogb.fsf@basil.nowhere.org>
Date:	Fri, 20 Jun 2008 16:21:40 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com,
	Kieran Mansley <kmansley@...arflare.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCH 1/2] net: Disable LRO on devices that are forwarding

Ben Hutchings <bhutchings@...arflare.com> writes:

> Large Receive Offload (LRO) is only appropriate for packets that are
> destined for the host, and should be disabled if received packets may be
> forwarded.  It can also confuse the GSO on output.
>
> Add dev_disable_lro() function which uses the appropriate ethtool ops to
> disable LRO if enabled.
>
> Add calls to dev_disable_lro() in br_add_if() and functions that enable
> IPv4 and IPv6 forwarding.

It might be a good idea to add a printk so that the user knows why
the device suddenly goes slower.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html