netdev - Re: [patch] fix 3c515.c:(.text+0x57200): undefined reference to `pnp_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080620155105.GB6656@elte.hu>
Date:	Fri, 20 Jun 2008 17:51:05 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [patch] fix 3c515.c:(.text+0x57200): undefined reference to
	`pnp_get_resource'


* Randy Dunlap <randy.dunlap@...cle.com> wrote:

> >     Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> Patch is in Jeff's tree.

i see. Hm, as far as i can see the patch was not Cc:-ed to lkml hence i 
did not see that it exist and created a patch for it. Please Cc: lkml 
for any mainline fix you think other people might trigger.

also, here's some small nitpicking about your patch:

+#ifdef __ISAPNP__
        if (idev) {
                irq = pnp_irq(idev, 0);
                vp->dev = &idev->dev;
        } else {
                irq = inw(ioaddr + 0x2002) & 15;
        }
+#else
+       irq = inw(ioaddr + 0x2002) & 15;
+#endif

as you now unconditonally assume that idev is NULL in the !__ISAPNP__. 
Which is true currently but might not be with other changes (which is 
unlikely but still). It also duplicates code visually.

So i'd still slightly prefer my patch instead of yours which avoids the 
duplication and puts the assumption/constraint straight in there via a 
BUG_ON():

> >  	if (idev) {
> > +#ifdef __ISAPNP__
> >  		irq = pnp_irq(idev, 0);
> > +#else
> > +		/* Can not happen - in the !PNP case we always pass in NULL */
> > +		BUG_ON(1);
> > +#endif
> >  		vp->dev = &idev->dev;
> >  	} else {
> >  		irq = inw(ioaddr + 0x2002) & 15;
> > --

no strong feelings though - it's a nitpick and this code is obviously 
obsolete.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html