netdev - Re: [PATCH] tcp: /proc/net/tcp rto,ato values not scaled properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080620123112.26202db9@extreme>
Date:	Fri, 20 Jun 2008 12:31:12 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: /proc/net/tcp rto,ato values not scaled properly

On Fri, 20 Jun 2008 12:05:26 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Fri, 20 Jun 2008 11:56:03 -0700
> 
> > I found another case where we are sending information to userspace
> > in the wrong HZ scale.  This should have been fixed back in 2.5 :-(
> > 
> > This means an ABI change but as it stands there is no way for an application
> > like ss to get the right value.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> Agree with your patch, but 'ss' should be getting this kind of info
> from netlink not procfs, right?
> 

Yes, ss tries netlink first and fallsback to /proc.

I am in process of making sure all usages of HZ in iproute utilities
are correct.  The old user code assumed that the hz value used by tc (psched)
was also correct for lots of other places. That is where I keep finding
these turds.

Soon all uses of get_hz() in iproute will be replaced with 
either get_psched_hz() for tc; get_user_hz for clock
values, or just use ms or us.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html