netdev - Re: [PATCH] netns: Don't receive new packets in a dead network namespace.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080620.221726.82764674.davem@davemloft.net>
Date:	Fri, 20 Jun 2008 22:17:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, den@...nvz.org, xemul@...nvz.org,
	dlezcano@...ibm.com, benjamin.thery@...l.net, adobriyan@...il.com
Subject: Re: [PATCH] netns: Don't receive new packets in a dead network
 namespace.

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Fri, 20 Jun 2008 17:17:05 -0700

> Alexey Dobriyan <adobriyan@...il.com> writes:
> > Subject: ICMP sockets destruction vs ICMP packets oops
 ...
> Receiving packets while we are cleaning up a network namespace is a
> racy proposition. It is possible when the packet arrives that we have
> removed some but not all of the state we need to fully process it.  We
> have the choice of either playing wack-a-mole with the cleanup routines
> or simply dropping packets when we don't have a network namespace to
> handle them.
> 
> Since the check looks inexpensive in netif_receive_skb let's just
> drop the incoming packets.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

Because of Alexey's positive test report, and the fact that it
looks OK to me, I'm adding this to net-2.6

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html