netdev - Re: [PATCH 1/8] textsearch: fix textsearch for case insensitive searching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485CB9F6.6050601@trash.net>
Date:	Sat, 21 Jun 2008 10:21:10 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Joonwoo Park <joonwpark81@...il.com>
CC:	netdev <netdev@...r.kernel.org>,
	netfilter-devel <netfilter-devel@...r.kernel.org>,
	Thomas Graf <tgraf@...g.ch>,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH 1/8] textsearch: fix textsearch for case insensitive searching

Joonwoo Park wrote:
> The function textsearch_prepare has new parameter to support case
> insensitive searching.
> 
> Signed-off-by: Joonwoo Park <joonwpark81@...il.com>
> ---
>  include/linux/textsearch.h          |    6 ++++--
>  lib/textsearch.c                    |    6 ++++--
>  net/netfilter/nf_conntrack_amanda.c |    2 +-
>  net/netfilter/xt_string.c           |    2 +-
>  net/sched/em_text.c                 |    2 +-
>  5 files changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/textsearch.h b/include/linux/textsearch.h
> index 6f371f2..b6897f3 100644
> --- a/include/linux/textsearch.h
> +++ b/include/linux/textsearch.h
> @@ -39,7 +39,7 @@ struct ts_state
>  struct ts_ops
>  {
>  	const char		*name;
> -	struct ts_config *	(*init)(const void *, unsigned int, gfp_t);
> +	struct ts_config *	(*init)(const void *, unsigned int, u8, gfp_t);


This looks fine to me, although a generic flags argument
would prevent changing all users again next time someone
wants to add a feature. But I'll leave that decision to
Thomas.

Thomas, since there are some netfilter patches that depend
on the textsearch patches, do you want me to apply those as
well (haven't reviewed them yet though)?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html