netdev - Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806211332.15944.opurdila@ixiacom.com>
Date:	Sat, 21 Jun 2008 13:32:15 +0300
From:	Octavian Purdila <opurdila@...acom.com>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO

On Saturday 21 June 2008, Jarek Poplawski wrote:

>
> Hmm..., I hope my ack will not hinder too much...
>

No, it actually helped making this a better patch and me learning a great 
deal.

> PS: I see this other "readability" patch seems to change even more, so
> I'll really need some free time to figure this out.
>

Sure, no hurry. To be honest this is a rewrite which I started to see if I 
understand the tcp read splice path properly. It ended up being cleaner than 
the original code so I thought I should share this - but of course being the 
one who wrote it I am completely biased on that assessment. So if it is not 
obviously more "readable" to someone else, than its probably not worth 
spending too much time on it  since we already have working / tested code :)

Thanks,
tavi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html