netdev - Re: [Patch] net/sched/sch_generic.c: fix an error pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080621195526.GA25715@hack.netcabo.pt>
Date:	Sat, 21 Jun 2008 20:55:26 +0100
From:	WANG Cong <xiyou.wangcong@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	wcong@...tical-links.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, kuznet@....inr.ac.ru
Subject: Re: [Patch] net/sched/sch_generic.c: fix an error pointer

On Thu, Jun 19, 2008 at 04:11:08PM -0700, David Miller wrote:
>From: WANG Cong <wcong@...tical-links.com>
>Date: Thu, 19 Jun 2008 15:37:14 +0100
>
>> ERR_PTR() ususally encodes an negative errno, not positive.
>> 
>> Note, in the following patch, 'err' is initialized as:
>> 
>> int err = -ENOBUFS;
>> 
>> Signed-off-by: WANG Cong <wcong@...tical-links.com>
>
>Patch is whitespace corruped and line wrapped by your
>email client.
>
>Please fix this and resubmit, thank you.

I am very sorry for this. Resend it with mutt. :-)

--------------->

ERR_PTR() ususally encodes an negative errno, not positive.

Note, in the following patch, 'err' is initialized as:

int err = -ENOBUFS;

Signed-off-by: WANG Cong <wcong@...tical-links.com>
Cc: David Miller <davem@...emloft.net>
Cc:  Alexey Kuznetsov <kuznet@....inr.ac.ru>

---
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index d355e5e..13afa72 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -468,7 +468,7 @@ struct Qdisc *qdisc_alloc(struct net_device *dev, struct Qdisc_ops *ops)
 
 	return sch;
 errout:
-	return ERR_PTR(-err);
+	return ERR_PTR(err);
 }
 
 struct Qdisc * qdisc_create_dflt(struct net_device *dev, struct Qdisc_ops *ops,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html