netdev - Re: [patch v2 01/11] DM9000: Remove the 2 resources probe scheme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080622203417.GA4050@solarflare.com>
Date:	Sun, 22 Jun 2008 21:34:18 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	netdev@...r.kernel.org, jeff@...zik.org,
	Laurent Pinchart <laurentp@...-semaphore.com>
Subject: Re: [patch v2 01/11] DM9000: Remove the 2 resources probe scheme.

Ben Dooks wrote:
> From: Laurent Pinchart <laurentp@...-semaphore.com>
> 
> The dm9000 driver accepts either 2 or 3 resources to describe the platform
> devices. The 2 resources case abuses the ioresource mechanism by passing
> ioremap()ed memory through the platform device resources. This patch removes
> that case and converts boards that were using it to the 3 resources scheme.
> 
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> Signed-off-by: Laurent Pinchart <laurentp@...-semaphore.com>
> ---
> 
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index 6bc8924..fca7831 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -528,7 +528,6 @@ dm9000_probe(struct platform_device *pdev)
>  	struct board_info *db;	/* Point a board information structure */
>  	struct net_device *ndev;
>  	const unsigned char *mac_src;
> -	unsigned long base;
>  	int ret = 0;
>  	int iosize;
>  	int i;
> @@ -561,78 +560,61 @@ dm9000_probe(struct platform_device *pdev)
>  	if (pdev->num_resources < 2) {
>  		ret = -ENODEV;
>  		goto out;
[...]

So shouldn't "< 2" be changed to "!= 3"?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html