netdev - Re: [PATCH] IRDA: Fix genlmsg_put() return value check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 22:29:05 +0200
From:	"Julius Volz" <juliusv@...gle.com>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	davem@...emloft.net, samuel@...tiz.org, netdev@...r.kernel.org
Subject: Re: [PATCH] IRDA: Fix genlmsg_put() return value check.

On Mon, Jun 23, 2008, Patrick McHardy wrote:
> Good catch, but the correct return value for insufficient
> space in the skb is -ENOSPC.

Hm, seems we have many inconsistent values returned in exactly this
situation (in response to genlmsg_put), but none of them are -ENOSPC:

fs/dlm/netlink.c: -EINVAL
net/netlink/genetlink.c: -1
net/netlabel/netlabel_unlabeled.c: -ENOMEM
net/netlabel/netlabel_cipso_v4.c: -ENOMEM
net/netlabel/netlabel_mgmt.c: -ENOMEM
net/wireless/nl80211.c: -1
drivers/acpi/event.c: -ENOMEM
kernel/taskstats.c: -EINVAL

Seems like -ENOMEM is most common, don't know if that means it's
correct, though...

I was also using -ENOMEM in my Netlink code, so better convert all my
new uses to -ENOSPC?

Julius

-- 
Google Switzerland GmbH
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html