netdev - RE: [2.6 patch] remove CONFIG_NET_SCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC3290549C885@orsmsx414.amr.corp.intel.com>
Date:	Mon, 23 Jun 2008 11:31:30 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"Adrian Bunk" <bunk@...nel.org>,
	"Patrick McHardy" <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>,
	"Robert P. J. Day" <rpjday@...shcourse.ca>
Subject: RE: [2.6 patch] remove CONFIG_NET_SCH_RR

>Commit d62733c8e437fdb58325617c4b3331769ba82d70
>([SCHED]: Qdisc changes and sch_rr added for multiqueue)
>added a NET_SCH_RR option that was unused since the code
>went unconditionally into sch_prio.

I don't agree we should remove this option, purely for the fact that
there isn't any way a user would know the qdisc existed without reading
the code.  I'd rather see a change to sch_prio.c to correctly wrap the
RR code, which I should have done in the first place.  My hurdle is when
the module is selected, NET_SCH_RR isn't defined to be used as an #ifdef
check in the code.  Only when it's selected to be built-in is the symbol
defined.  If I can get around that, I'll generate a patch to properly
wrap sch_prio.c code.  I know I'm missing something silly, so any
guidance is appreciated.

-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html