netdev - Re: [PATCH] net-driver: Drivers don't set IFF_* flag [Was: [PATCH 3/3] netdevice: order of synchronization of IFF_PROMISC and IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2008 13:39:19 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	Grant Grundler <grundler@...isc-linux.org>
CC:	Patrick McHardy <kaber@...sh.net>, Jeff Garzik <jgarzik@...ox.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	NETDEV <netdev@...r.kernel.org>, kyle@...isc-linux.org
Subject: Re: [PATCH] net-driver: Drivers don't set IFF_* flag [Was: [PATCH
 3/3] netdevice: order of synchronization of IFF_PROMISC and	IFF_ALLMULTI]

Grant Grundler said the following on 2008-6-24 13:10:
> On Tue, Jun 24, 2008 at 09:02:03AM +0800, Wang Chen wrote:
> ...
>> So I want to remove "clear promisc" feature by ioctl of this driver
>> instead of adding it to feature-removal-schedule.
>> "set promisc" feature by ioctl can be fixed temporarily and should be
>> added to feature-removal-schedule. 
>> Fortunately most of the features of this driver's ioctl are for
>> developer testing.
>>
>> This week I want to wait for tulip driver maintainer's confirmation.
> 
> Confirmation of what?
> Apologies for not being able to follow the whole conversation.
> 

Sorry for that I cc-ed you in the mid of discussion.
Patrick and me were discussing about that driver should not
change device's promisc mode, because it's not a boolean state,
but a refcnt to decide whether IFF_PROMISC should be set or not.

In de4x5_ioctl(), user can simply set IFF_PROMISC flag and that
can cause upper layer protocol broken.

Patrick suggest to use dev_change_flags() to change IFF_PROMISC
flag and add the feature to feature-removal-schedule.

My suggestion is that we remove IFF_PROMISC changing feature from
de4x5_ioctl() now.

> If you want to remove a developer debug feature, please just submit
> a patch like usual to kyle and myself.
> 

Is there any user space binary use these features?
case DE4X5_SET_PROM:
case DE4X5_CLR_PROM: 
If not, I will send a patch to remove them.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html