netdev - Re: [PATCH (regression)] Fragments: fix race between inet_frag_find and inet_frag_secret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080625.000903.262554536.davem@davemloft.net>
Date:	Wed, 25 Jun 2008 00:09:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH (regression)] Fragments: fix race between
 inet_frag_find and inet_frag_secret_rebuild

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Wed, 25 Jun 2008 10:42:56 +0400

> Jarek Poplawski wrote:
> > Maybe it's a matter of taste: since there is this "#ifdef CONFIG_SMP",
> > and the new comment concerns with "other CPU", why this re-calculation
> > isn't done only for SMP? 
> 
> Because the hash value is required also *outside* this ifdef and adding
> a fancier logic is probably not good for a -rc7 fix.
> 
> However, I will re-consider this for net-next.
> 
> > And, btw., probably __acquires/__releases annotations could be added
> > with this patch.
> 
> This is also a net-next material (I hope Dave agrees with me on both).

I do. :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html