netdev - Re: [PATCH 1/4] e1000: disable TSO workaround on 82544

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390806250150v75965ff6k6773288fe1b28089@mail.gmail.com>
Date:	Wed, 25 Jun 2008 01:50:40 -0700
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Andy Gospodarek" <andy@...yhouse.net>,
	"Jeff Garzik" <jeff@...zik.org>
Cc:	netdev@...r.kernel.org, jesse.brandeburg@...el.com
Subject: Re: [PATCH 1/4] e1000: disable TSO workaround on 82544

On Thu, Jun 19, 2008 at 2:18 PM, Andy Gospodarek <andy@...yhouse.net> wrote:
>
> It appears that the 82544 does not need the TSO workaround needed on
> other chips.  This seems to resolve excessive messages that appear to be
> Tx Unit Hangs when a system is under heavy stress.
>
> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
> ---
>  drivers/net/e1000/e1000_main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index 59579b1..af6846d 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -3479,7 +3479,8 @@ e1000_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
>        }
>
>        if (likely(tso)) {
> -               tx_ring->last_tx_tso = 1;
> +               if (likely(adapter->hw.mac_type != e1000_82544))
> +                       tx_ring->last_tx_tso = 1;
>                tx_flags |= E1000_TX_FLAGS_TSO;
>        } else if (likely(e1000_tx_csum(adapter, tx_ring, skb)))
>                tx_flags |= E1000_TX_FLAGS_CSUM;
> --
> 1.5.2.1
>

ACK - patches 1-4
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html