netdev - Re: [PATCH] igb: completely disable interrupts during netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080626024040.GB32408@gospo.rdu.redhat.com>
Date:	Wed, 25 Jun 2008 22:40:40 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	David Miller <davem@...emloft.net>
Cc:	matthew@....cx, jesse.brandeburg@...el.com,
	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	john.ronciak@...el.com, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] igb: completely disable interrupts during netpoll

On Wed, Jun 25, 2008 at 05:29:11PM -0700, David Miller wrote:
> From: Andy Gospodarek <andy@...yhouse.net>
> Date: Wed, 25 Jun 2008 16:39:31 -0400
> 
> > Just for the record, most of the other net-drivers do it
> > this way too.
> 
> Ummm, really?
> 
> No NAPI based driver I ever wrote does this.

For the poll_controller routines (which is what this patch is about),
quite a few do (bnx2, bnx2x, b44, e1000, and e1000e to name a few).

Much like the other drivers for Intel hardware, the function with
'netpoll' in the name is used for the poll_controller routine whereas
the napi poll routines all have 'clean' in the name.

Sorry if 'most' was misleading, but there are quite a few drivers that
do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html