netdev - Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080626055907.GD1369@1wt.eu>
Date:	Thu, 26 Jun 2008 07:59:07 +0200
From:	Willy Tarreau <w@....eu>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, Jie.Yang@...eros.com, jeff@...zik.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver

On Wed, Jun 25, 2008 at 10:55:50PM -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Wed, 25 Jun 2008 22:48:29 -0700
> 
> > I would prefer that the driver be NAPI only, because configuration
> > choices are hard for users and distribution to make correct
> > choice. Plus it means two choices for your QA to test.
> 
> I agree with Stephen.
> 
> It's absolutely to provide a non-NAPI option, please just remove
> the option and the conditionals from the code.

Also I think it's useless to provide one patch per source file. It'd
be better to have one whole patch, or several ones if some features
may be added incrementally.

Willy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html