netdev - Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200806261138.04192.laurentp@cse-semaphore.com>
Date:	Thu, 26 Jun 2008 11:38:03 +0200
From:	Laurent Pinchart <laurentp@...-semaphore.com>
To:	matvejchikov@...il.com
Cc:	"Bill Fink" <billfink@...dspring.com>, linuxppc-dev@...abs.org,
	netdev@...r.kernel.org, pantelis.antoniou@...il.com,
	vbordug@...mvista.com
Subject: Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

Hi,

On Friday 20 June 2008 10:55, Matvejchikov Ilya wrote:
> >> > diff --git a/drivers/net/fs_enet/mac-fcc.c 
b/drivers/net/fs_enet/mac-fcc.c
> >> > index ce40cf9..1a95cf1 100644
> >> > --- a/drivers/net/fs_enet/mac-fcc.c
> >> > +++ b/drivers/net/fs_enet/mac-fcc.c
> >> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev)
> >> >             C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
> >> >
> >> >     S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);
> >> > +
> >> > +   /* Restore multicast and promiscous settings */
> >> > +   set_multicast_list(dev);
> >> >  }
> 
> Is it right to call set_multicast_list() after turning on transmitter
> and receiver? May be swap this lines around?

I'm not sure if that will make a difference, but you're right, restoring the 
multicast and promiscuous settings is better done before turning the receiver 
and transmitter on.

I'll send a new patch.

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

Content of type "application/pgp-signature" skipped