netdev - Re: [PATCH] igb: completely disable interrupts during netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200806261152.06092.jbarnes@virtuousgeek.org>
Date:	Thu, 26 Jun 2008 11:52:05 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	David Miller <davem@...emloft.net>
Cc:	andy@...yhouse.net, matthew@....cx, jesse.brandeburg@...el.com,
	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	john.ronciak@...el.com, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] igb: completely disable interrupts during netpoll

On Wednesday, June 25, 2008 7:43 pm David Miller wrote:
> From: Andy Gospodarek <andy@...yhouse.net>
> Date: Wed, 25 Jun 2008 22:40:40 -0400
>
> > For the poll_controller routines (which is what this patch is about),
> > quite a few do (bnx2, bnx2x, b44, e1000, and e1000e to name a few).
> >
> > Much like the other drivers for Intel hardware, the function with
> > 'netpoll' in the name is used for the poll_controller routine whereas
> > the napi poll routines all have 'clean' in the name.
>
> Thanks for the clarification.
>
> I'm still curious what the deadlock case is.  It might be something
> we should fix elsewhere too.

I'm curious too... Also, won't using disable_irq() rather than a device 
specific method break the shared irq case?  It looks like free_irq() handles 
that, but not disable_irq().

Jesse
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html