netdev - Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead adaption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080627023142.g4lopi8l8g8kw8kw@hayate.ip6>
Date:	Fri, 27 Jun 2008 02:31:42 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	lists@...yfurniss.entadsl.com, netdev@...r.kernel.org,
	Stephen Hemminger <shemminger@...l.org>
Subject: Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead
	adaption

Quoting Patrick McHardy <kaber@...sh.net>:

> Jussi Kivilinna wrote:
>> Quoting Andy Furniss <lists@...yfurniss.entadsl.com>:
>>
>>> Jussi Kivilinna wrote:
>>>> Patch adds 'mpu', 'mtu', 'overhead' and 'linklayer' options to hfsc. These
>>>> options are used to create size table for sch_hfsc. Size table is  
>>>>  only used
>>>> and passed to kernel if these options are used.
>>>
>>>> +    unsigned short overhead = 0, mpu = 0;
>>>
>>> overhead may need to be negative because skb->len on eth is payload + 14
>>>
>>> Andy.
>>
>> Ok, I made size tables use signed short for overhead instead.
>
> Please wait with resending until I get a chance to review the
> patches (probably later today) in case something else comes up.

Ok.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html