netdev - Re: [PATCH] TCP MD5 and TSO/SG breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <396556a20806271128r5dddd07fu1affc8f61a19889b@mail.gmail.com>
Date:	Fri, 27 Jun 2008 11:28:15 -0700
From:	"Adam Langley" <agl@...erialviolet.org>
To:	"Stephen Hemminger" <stephen.hemminger@...tta.com>
Cc:	"David Miller" <davem@...emloft.net>,
	"吉藤英明" <yoshfuji@...ux-ipv6.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] TCP MD5 and TSO/SG breakage

On Fri, Jun 27, 2008 at 11:21 AM, Stephen Hemminger
<stephen.hemminger@...tta.com> wrote:
> The TCP MD5 support is broken on any device that does scatter gather.
> The MD5 calculation code doesn't support scatter/gather, the md5_calc
> API assumes the data follows the TCP header. It is too late to rework this
> code for 2.6.26 (and backport to stable). So the sane thing to do is block
> use of SG on TCP sockets using MD5 option.

Acked-By: Adam Langley <agl@...erialviolet.org>


AGL

-- 
Adam Langley agl@...erialviolet.org http://www.imperialviolet.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html