netdev - Re: [PATCH 3/3] e1000e: fix EEH recovery during reset on PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <486472F1.4050900@garzik.org>
Date:	Fri, 27 Jun 2008 00:56:17 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, pl@...ibm.com
Subject: Re: [PATCH 3/3] e1000e: fix EEH recovery during reset on PPC

Jeff Kirsher wrote:
> EEH is not recovering in a reasonable amount of time on PPC during
> e1000e_down().
> 
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> 
>  drivers/net/e1000e/netdev.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index ccb8ca2..0320925 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -2535,7 +2535,8 @@ void e1000e_down(struct e1000_adapter *adapter)
>  	adapter->link_speed = 0;
>  	adapter->link_duplex = 0;
>  
> -	e1000e_reset(adapter);
> +	if (!pci_channel_offline(adapter->pdev))
> +		e1000e_reset(adapter);
>  	e1000_clean_tx_ring(adapter);
>  	e1000_clean_rx_ring(adapter);

IMO for this type of change, you should consider putting all these 
changes into a single patch.

It's exactly the same logical change, so no need to split it up into 
three patches.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html