netdev - Re: [PATCH] Fix IOMMU overflow checking in s2io.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2008 01:32:36 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andi Kleen <andi@...stfloor.org>
CC:	netdev@...r.kernel.org, ram.vepa@...erion.com,
	santosh.rastapur@...erion.com, sivakumar.subramani@...erion.com,
	sreenivasa.honnur@...erion.com
Subject: Re: [PATCH] Fix IOMMU overflow checking in s2io.c

Andi Kleen wrote:
> Fix IOMMU overflow checking in s2io.c
> 
> s2io has IOMMU overflow checking, but unfortunately it is wrong.
> 
> It didn't use the standard macros, which meant that it only worked
> on POWER and SPARC because only those define DMA_ERROR_CODE. Convert it to 
> use the standard macros instead.
> 
> I also commented two more bugs in the IOMMU handling. It assumes
> that 0 DMA addresses cannot happen, but that's not true in all IOMMU setups.
> The information if a buffer has been already mapped needs to be stored
> elsewhere.
> 
> Didn't fix those because it needs careful checking of the buffer handling
> by the maintainers.
> 
> Cc: ram.vepa@...erion.com
> Cc: santosh.rastapur@...erion.com
> Cc: sivakumar.subramani@...erion.com
> Cc: sreenivasa.honnur@...erion.com
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html