netdev - Re: [PATCH] 8139too: some style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48648427.8000606@pobox.com>
Date:	Fri, 27 Jun 2008 02:09:43 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Németh Márton <nm127@...email.hu>
CC:	Stefan Richter <stefanr@...6.in-berlin.de>,
	David Newall <davidn@...idnewall.com>, netdev@...r.kernel.org,
	Trivial Patch Monkey <trivial@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 8139too: some style cleanups

Németh Márton wrote:
> From: Márton Németh <nm127@...email.hu>
> 
> Clean up the following errors and warnings reported by checkpatch.pl:
>  + ERROR: Macros with complex values should be enclosed in parenthesis
>  + WARNING: __func__ should be used instead of gcc specific __FUNCTION__
>  + WARNING: plain inline is preferred over __inline__
>  + WARNING: Use #include <linux/io.h> instead of <asm/io.h>
>  + WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> 
> The changes were verified with by comparing the "objdump -d 8139too.ko"
> output which is exactly the same for the old and new version in case of
> config CONFIG_8139TOO=m, CONFIG_8139TOO_PIO=n, CONFIG_8139TOO_TUNE_TWISTER=n,
> CONFIG_8139TOO_8129=n, CONFIG_8139_OLD_RX_RESET=n.
> Software versions used: gcc 4.2.3, objdump 2.18.0.20080103, on elf32-i386.
> 
> Signed-off-by: Márton Németh <nm127@...email.hu>

applied, thanks for whittling down the changes to this set


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html