lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 27 Jun 2008 02:09:43 -0400
From:	Jeff Garzik <>
To:	Németh Márton <>
CC:	Stefan Richter <>,
	David Newall <>,,
	Trivial Patch Monkey <>,
	LKML <>
Subject: Re: [PATCH] 8139too: some style cleanups

Németh Márton wrote:
> From: Márton Németh <>
> Clean up the following errors and warnings reported by
>  + ERROR: Macros with complex values should be enclosed in parenthesis
>  + WARNING: __func__ should be used instead of gcc specific __FUNCTION__
>  + WARNING: plain inline is preferred over __inline__
>  + WARNING: Use #include <linux/io.h> instead of <asm/io.h>
>  + WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> The changes were verified with by comparing the "objdump -d 8139too.ko"
> output which is exactly the same for the old and new version in case of
> CONFIG_8139TOO_8129=n, CONFIG_8139_OLD_RX_RESET=n.
> Software versions used: gcc 4.2.3, objdump, on elf32-i386.
> Signed-off-by: Márton Németh <>

applied, thanks for whittling down the changes to this set

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists