netdev - Re: [PATCH 6/8 v2] netfilter: fix string extension for case insensitive pattern matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b25c3fa70806270249m2a6e8962r6e8e1fd3c18d82a0@mail.gmail.com>
Date:	Fri, 27 Jun 2008 02:49:34 -0700
From:	"Joonwoo Park" <joonwpark81@...il.com>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	netdev <netdev@...r.kernel.org>,
	netfilter-devel <netfilter-devel@...r.kernel.org>,
	"Thomas Graf" <tgraf@...g.ch>,
	"Pablo Neira Ayuso" <pablo@...filter.org>
Subject: Re: [PATCH 6/8 v2] netfilter: fix string extension for case insensitive pattern matching

2008/6/26 Patrick McHardy <kaber@...sh.net>:
> Joonwoo Park wrote:
>>
>> netfilter: fix string extension for case insensitive pattern matching
>>
>> The flag XT_STRING_FLAG_IGNORECASE indicates case insensitive string
>> matching.
>> netfilter can find cmd.exe, Cmd.exe, cMd.exe and etc easily.
>>
>> Also this patch won't break compatibility since we have 2 bytes space
>> between invert and config, due to config was 8 bytes aligned.
>> So we can put a new value 'flags' in xt_string_info between invert and
>> config safely.
>> If previous version of iptables interact with this kernel, to kernel
>> side, flags will be set to zero and to user side, flags will be ignored.
>
> This makes it hard for userspace to know whether insensitive
> search is supported or not, similar for possible future flag
> additions.
>
> Please
>
> - add a new revision for userspace to know whether flags are
>  supported at all. You don't need to duplicate the checkentry
>  function for this since the structure layout didn't change,
>  you can simply parse flags dependant on match->revision.
>  Userspace can use the existance of the new revision as
>  indication that flags are supported.
>
> - check for unknown flags and return an error
>

Hi Patrick,
Thanks for your advice.
Since I'm traveling America, so maybe I could catch up these things
you've asked next weekend.
I don't need to rush, do I?

Thanks again,
Joonwoo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html