netdev - Re: [PATCH] Prevent from potential dead lock for inet_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080627.193234.134186954.davem@davemloft.net>
Date:	Fri, 27 Jun 2008 19:32:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	guijianfeng@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Prevent from potential dead lock for inet_listen_lock

From: Gui Jianfeng <guijianfeng@...fujitsu.com>
Date: Fri, 20 Jun 2008 17:08:20 +0800

> hashinfo->lhash_lock might be acquired by write_lock() in softirq, 

How?

> so using read_lock() here isn't safe, just substitudes by read_lock_bh().
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>

I don't think this is necessary.

The only place the write lock is obtained, is via
the ->hash() and ->unhash() sk_prot operation methods.

And for listening sockets that only occurs in normal base
context.  Never from softirqs.

If there is a patch from softirqs where this can occur,
that is a bug and must be fixed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html