netdev - Re: [PATCH v2] net/inet_lro: remove setting skb->ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080627.200914.146689237.davem@davemloft.net>
Date:	Fri, 27 Jun 2008 20:09:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eli@....mellanox.co.il
Cc:	netdev@...r.kernel.org, THEMANN@...ibm.com,
	general@...ts.openfabrics.org, or.gerlitz@...il.com,
	vlad@...lanox.co.il, rdreier@...co.com
Subject: Re: [PATCH v2] net/inet_lro: remove setting skb->ip_summed when
 not LRO-able

From: Eli Cohen <eli@....mellanox.co.il>
Date: Wed, 25 Jun 2008 18:29:12 +0300

> When an SKB cannot be chained to a session, the current code attempts
> to "restore" its ip_summed field from lro_mgr->ip_summed. However,
> lro_mgr->ip_summed does not hold the original value; in fact, we'd
> better not touch skb->ip_summed since it is not modified by the code
> in the path leading to a failure to chain it.
> Also use a cleaer comment to the describe the ip_summed field of
> struct net_lro_mgr.
> 
> Issue raised by Or Gerlitz <ogerlitz@...taire.com>
> 
> Signed-off-by: Eli Cohen <eli@...lanox.co.il>

Patch applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html