lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 29 Jun 2008 21:25:21 +0200
From:	Pidoux <f6bvp@...e.fr>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, ralf@...ux-mips.org,
	linux-hams@...r.kernel.org
Subject: [ROSE] unregister_netdevice: waiting for rose0 to become free

A bug in ROSE protocol is preventing removal of rose module.

After killing all ROSE and AX25 applications, there are no more sockets and
rose usage count is correctly decreased to null as seen in /proc/modules :

rose 40120 0 - Live 0xe1071000

However, issuing command rmmod rose displays the following message in loop forever :

kernel: unregister_netdevice: waiting for rose0 to become free. Usage count = 2

Usage count can be different and seems random (not correlated with module usage count reached when ROSE
applications are loaded).

Tracing the problem shows that above message is sent by core/dev.c

Here is the loop :

while (atomic_read(&dev->refcnt) !=0) {
....
}

Obviously, displayed usage count (dev->refcnt) is not the same as in /proc/modules or given by command
lsmod and also it is not decremented, i.e. it stays at the same, and probably not relevant, value.

A comment in core/dev.c says that buggy protocol don't correctly call dev_put().

I tried to review rose module source but I have not been able to find a correct place where dev_put(dev) could be 
missing either in af_rose.c or rose_route.c.

Maybe the problem is elsewhere ?

Bernard Pidoux, f6bvp
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists