netdev - Re: [PATCH] net: em_cmp.c use unaligned access helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080629232638.GO20815@postel.suug.ch>
Date:	Mon, 30 Jun 2008 01:26:39 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: em_cmp.c use unaligned access helpers

* Harvey Harrison <harvey.harrison@...il.com> 2008-06-29 11:01
> OK, but be16/32_to_cpu is a no-op on be-arches, so there is a bug here on
> big-endian machines as they won't switch it back, your simplified patch
> is actually a bugfix in that case.

I noticed that my change wouldn't be correct. The point is to allow
userspace to convert the filter values to big endian once, supply them
to the kernel and compare big endian values directly. The be16/32_to_cpu
convertion is available to support greater-than/lesser-than on little
endian architectures.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html