netdev - Re: [PATCH 1/2] r8169: multicast register update (sync with Realtek's 8.004.00 8168 driver)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2008 11:02:57 +0100
From:	Glen Gray <glen.gray@...cor.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	jeff@...zik.org, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Edward Hsu <edward_hsu@...ltek.com.tw>
Subject: Re: [PATCH 1/2] r8169: multicast register update (sync with Realtek's 8.004.00 8168 driver)

Hey Francois,

Do you think this might resolve my issues with multicast SAP  
announcements ?
--
Glen Gray <glen.gray@...cor.com>         Digital Depot, Thomas Street
Software Engineering Manager                        Dublin 8, Ireland
Lincor Solutions Ltd.                          Ph: +353 (0) 1 4893682

On 29 Jun 2008, at 14:18, Francois Romieu wrote:

> The layout of the 8168 serie is different from that of the 8110 one.
>
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Edward Hsu <edward_hsu@...ltek.com.tw>
> ---
> drivers/net/r8169.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 6572425..9086e81 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -3098,8 +3098,10 @@ static void rtl_set_rx_mode(struct net_device  
> *dev)
> 	    (tp->mac_version == RTL_GIGA_MAC_VER_15) ||
> 	    (tp->mac_version == RTL_GIGA_MAC_VER_16) ||
> 	    (tp->mac_version == RTL_GIGA_MAC_VER_17)) {
> -		mc_filter[0] = 0xffffffff;
> -		mc_filter[1] = 0xffffffff;
> +		u32 data = mc_filter[0];
> +
> +		mc_filter[0] = swab32(mc_filter[1]);
> +		mc_filter[1] = swab32(data);
> 	}
>
> 	RTL_W32(MAR0 + 0, mc_filter[0]);
> -- 
> 1.5.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html