netdev - Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2008 08:50:41 -0400
From:	"Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil>
To:	David Woodhouse <dwmw2@...radead.org>
cc:	netdev@...r.kernel.org, linux-atm-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()

In message <1214818473.10393.337.camel@...c.infradead.org>,David Woodhouse writ
es:
>Sorry for dropping this; I'll let it go through the net tree now it's
>there.

ok

>A couple of comments though... it looks like you forgot to add
>MODULE_FIRMWARE(). And shouldn't 'fw_data' in

yes.  i will get davem a patch for that asap.

>fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?

yes, it certainly could be.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html