netdev - Re: MD5 SG fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <396556a20807011448m534c4c8dvf0b827f4cead4714@mail.gmail.com>
Date:	Tue, 1 Jul 2008 14:48:31 -0700
From:	"Adam Langley" <agl@...erialviolet.org>
To:	"Stephen Hemminger" <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org
Subject: Re: MD5 SG fix

On Tue, Jul 1, 2008 at 2:39 PM, Stephen Hemminger <shemminger@...tta.com> wrote:
> I would rather see the pool used less and the stack used more.
> Global context is more like FORTRAN common blocks.

Will do. My only concern was that it was 214 bytes which could easily
not be on the stack.

> My suggestion would be to have two hash functions, one that takes a block
> for the cases of TCP SYN, etc. and another that takes an skb for data packets.

You're probably right. If it works I'll break it out like that.

> You still need to have some of the places that reset sk_route_caps otherwise
> you will get TSO/GSO packets because of the resetting of route_caps after the SYN/ACK.

I've copied the hunks from [1] where sk_route_caps were added (not
just changed from ~GSO to ~(GSO|SG)). Hopefully those are the right
ones. I'll resend in a sec.


Cheers,

AGL

-- 
Adam Langley agl@...erialviolet.org http://www.imperialviolet.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html