netdev - Re: How come realtek drivers are combined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080701215806.GA804@electric-eye.fr.zoreil.com>
Date:	Tue, 1 Jul 2008 23:58:06 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Mario Limonciello <mario_limonciello@...l.com>
Cc:	netdev@...r.kernel.org, edward_hsu@...ltek.com.tw
Subject: Re: How come realtek drivers are combined

Francois Romieu <romieu@...zoreil.com> :
> Mario Limonciello <mario_limonciello@...l.com> :
[...]
> > Now I did see a fair deal of patches floating in from you, so I'll clone
> > your netdev git tree and give this a run on some of the RTL8101's that
> > are having trouble.
> 
> Don't expect miracle: the 8101/8102 part is not floating yet.

That being said, you can give a try to the version of the day at
http://userweb.kernel.org/~romieu/r8169/2.6.26-rc6/ and apply the
patch below to it:

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 8d18bb6..860a472 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2547,8 +2547,13 @@ static void rtl_hw_start_8101(struct net_device *dev)
 
 	if ((tp->mac_version == RTL_GIGA_MAC_VER_13) ||
 	    (tp->mac_version == RTL_GIGA_MAC_VER_16)) {
-		pci_write_config_word(pdev, 0x68, 0x00);
-		pci_write_config_word(pdev, 0x69, 0x08);
+		int cap;
+
+		cap = pci_find_capability(pdev, PCI_CAP_ID_EXP);
+		if (cap != 0) {
+			pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL,
+					      PCI_EXP_DEVCTL_NOSNOOP_EN);
+		}
 	}
 
 	RTL_W8(Cfg9346, Cfg9346_Unlock);

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html