netdev - Re: MD5 SG fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080701161053.43c0b627@speedy>
Date:	Tue, 1 Jul 2008 16:10:53 -0700
From:	Stephen Hemminger <stephen.hemminger@...tta.com>
To:	"Adam Langley" <agl@...erialviolet.org>
Cc:	"Stephen Hemminger" <shemminger@...tta.com>, netdev@...r.kernel.org
Subject: Re: MD5 SG fix

On Tue, 1 Jul 2008 15:52:56 -0700
"Adam Langley" <agl@...erialviolet.org> wrote:

> On Tue, Jul 1, 2008 at 3:49 PM, Stephen Hemminger <shemminger@...tta.com> wrote:
> > Just pass the skb in and not tcplen, frags, ...
> > avoid all this nonsense.  tcplen == skb->len, and you have the correct size info.
> 
> But there are places where that function is called that we don't have
> an SKB to pass in (tcp_v6_send_reset and tcp_v6_send_ack, likewise in
> v4). I could duplicate the whole function, once for SKBs and once for
> those users, but that's a bunch of duplicated code. I'll defer to your
> experience on what the kernel's preferred practice is here.
> 

Break the calc function into:
   setup header
   setup data
   calculate

Then make two handles, one for data block, other for skb

If you want, let's take this off list and I'll bounce you back what I mean.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html