netdev - Re: [PATCH] pasemi_mac: Access iph->tot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080702042426.GA27717@lixom.net>
Date:	Tue, 1 Jul 2008 23:24:26 -0500
From:	Olof Johansson <olof@...om.net>
To:	Roland Dreier <rdreier@...co.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH] pasemi_mac: Access iph->tot_len with correct endianness

On Tue, Jul 01, 2008 at 10:22:45AM -0700, Roland Dreier wrote:
> iph->tot_len is stored in network byte order, so access it using
> ntohs().  This doesn't have any real world impact on pasemi_mac, since
> the device only exists as part of a big-endian system-on-chip, but
> fixing this gets rid of a sparse warning and avoids having a bad example
> in the tree.
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>

Acked-by: Olof Johansson <olof@...om.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html