netdev - Re: [PATCH] ipv6: Do cleanup for ip_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080702.181831.32808810.yoshfuji@linux-ipv6.org>
Date:	Wed, 02 Jul 2008 18:18:31 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	wangchen@...fujitsu.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ipv6: Do cleanup for ip_mr_init

In article <48606D1B.3040507@...fujitsu.com> (at Tue, 24 Jun 2008 11:42:19 +0800), Wang Chen <wangchen@...fujitsu.com> says:

> If do not do it, we will get following issues:
> 1. Leaving junks after inet6_init failing halfway.
> 2. Leaving proc and notifier junks after ipv6 modules unloading.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

> diff --git a/include/linux/mroute6.h b/include/linux/mroute6.h
> index e798959..05ffaac 100644
> --- a/include/linux/mroute6.h
> +++ b/include/linux/mroute6.h
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index e84b3fd..15d4138 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -1115,7 +1118,9 @@ static void __exit inet6_exit(void)
>  	ipv6_netfilter_fini();
>  	igmp6_cleanup();
>  	ndisc_cleanup();
> +#ifdef CONFIG_IPV6_MROUTE
>  	icmpv6_cleanup();
> +#endif
>  	rawv6_exit();
>  
>  	unregister_pernet_subsys(&inet6_net_ops);

Well we really need this #ifdef ... #endif?

And well, would you please make ip6_mr_init() return
error and handle it correctly?

We need to fix ipv4-side as well.

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html