netdev - Re: [PATCH] Fix missing const in vortex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080702113209.GA7469@bayes.mathematik.tu-chemnitz.de>
Date:	Wed, 2 Jul 2008 13:32:09 +0200
From:	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
To:	David Howells <dhowells@...hat.com>,
	Jeff Garzik <jgarzik@...ox.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix missing const in vortex_probe1() in the 3c59x driver

On Fri, Jun 27, 2008 at 01:12:20PM +0100, David Howells wrote:
> In vortex_probe1() in the 3c59x driver, print_name should be made a const
> pointer to eliminate the following warning:
> 
> drivers/net/3c59x.c:1025: warning: assignment discards qualifiers from pointer target type
> 
> This is this line:
> 
> 			print_name = pci_name(pdev);
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
Acked-by: Steffen Klassert <klassert@...hematik.tu-chemnitz.de>

Thanks,

Steffen

> ---
> 
>  drivers/net/3c59x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
> index 2edda8c..5972114 100644
> --- a/drivers/net/3c59x.c
> +++ b/drivers/net/3c59x.c
> @@ -1010,7 +1010,7 @@ static int __devinit vortex_probe1(struct device *gendev,
>  	static int printed_version;
>  	int retval, print_info;
>  	struct vortex_chip_info * const vci = &vortex_info_tbl[chip_idx];
> -	char *print_name = "3c59x";
> +	const char *print_name = "3c59x";
>  	struct pci_dev *pdev = NULL;
>  	struct eisa_device *edev = NULL;
>  	DECLARE_MAC_BUF(mac);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html