netdev - Re: v2 [PATCH net-next 1/8] af_packet: Check return of dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080701.195609.05458287.davem@davemloft.net>
Date:	Tue, 01 Jul 2008 19:56:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: v2 [PATCH net-next 1/8] af_packet: Check return of
 dev_set_promiscuity/allmulti

From: Wang Chen <wangchen@...fujitsu.com>
Date: Tue, 01 Jul 2008 11:31:14 +0800

> Wang Chen said the following on 2008-7-1 11:21:
> > dev_set_promiscuity/allmulti might overflow.
> > Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
> > dev_set_promiscuity/allmulti return error number if overflow happened.
> > 
> > In af_packet, we check all positive increment for promiscuity and allmulti
> > to get error return.
> > 
> 
> oops, the subject should be 1/7.
> sorry :(

I understood this :)

Please make the fixes requested by Patrick and resubmit.
The patches look otherwise fine to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html