netdev - Re: [PATCH 06/39]: netdev: ->ingress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080703.030241.34728979.davem@davemloft.net>
Date:	Thu, 03 Jul 2008 03:02:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org, vinay@...ux.vnet.ibm.com,
	krkumar2@...ibm.com, mchan@...adcom.com, Matheos.Worku@....COM,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 06/39]: netdev: ->ingress_lock is no longer needed.

From: Wang Chen <wangchen@...fujitsu.com>
Date: Thu, 03 Jul 2008 17:55:30 +0800

> David Miller said the following on 2008-7-3 15:03:
> > @@ -2014,10 +2014,11 @@ static inline struct sk_buff *handle_macvlan(struct sk_buff *skb,
> >   */
> >  static int ing_filter(struct sk_buff *skb)
> >  {
> > -	struct Qdisc *q;
> >  	struct net_device *dev = skb->dev;
> > -	int result = TC_ACT_OK;
> >  	u32 ttl = G_TC_RTTL(skb->tc_verd);
> > +	struct netdev_queue *rxq;
> > +	int result = TC_ACT_OK;
> > +	struct Qdisc *q;
> >  
> 
> Two lines do not change anything.

They make the variables have a nice style slope from longest
lines to the shortest.

If I'm going to edit this much of the TX path, I'm going to
cleanup coding style details like this along the way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html