netdev - Re: [PATCH 26/39]: netdev: netdev_priv() can now be sane again.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080703.042614.244608628.davem@davemloft.net>
Date:	Thu, 03 Jul 2008 04:26:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	khc@...waw.pl
Cc:	netdev@...r.kernel.org, vinay@...ux.vnet.ibm.com,
	krkumar2@...ibm.com, mchan@...adcom.com, Matheos.Worku@....COM,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 26/39]: netdev: netdev_priv() can now be sane again.

From: Krzysztof Halasa <khc@...waw.pl>
Date: Thu, 03 Jul 2008 13:23:32 +0200

> David Miller <davem@...emloft.net> writes:
> 
> > The private area of a netdev is now at a fixed offset once more.
> >
> > Unfortunately, some assumptions that netdev_priv() == netdev->priv
> > crept back into the tree.  In particular this happened in the
> > loopback driver.
> 
> Perhaps the netdev_priv() should be renamed to avoid confusion?

If all drivers call netdev_priv(), there is no confusion :)

I plan to rename dev->priv to dev->_priv and fix all the fallout.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html