netdev - Re: [PATCH] xfrm: Fix inter family IPsec tunnel handling again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080703091836.GK9549@secunet.com>
Date:	Thu, 3 Jul 2008 11:18:36 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>, kaber@...sh.net,
	netdev@...r.kernel.org, klassert@...hematik.tu-chemnitz.de
Subject: Re: [PATCH] xfrm: Fix inter family IPsec tunnel handling again

On Thu, Jul 03, 2008 at 05:05:22PM +0800, Herbert Xu wrote:
> On Thu, Jul 03, 2008 at 10:55:42AM +0200, Steffen Klassert wrote:
> >
> > +#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
> > +        case IPPROTO_IPV6:
> > +                if (!pskb_may_pull(skb, sizeof(struct ipv6hdr)))
> > +                        goto out;
> > +                break;
> > +#endif
> 
> This is supposed to use protocol-agnostic data so why do you need
> the ifdef?
> 
Well, I added the ifdef because it was there in the 2.6.24 code,
I could remove it and resend if you agree with the rest of the patch.

Steffen
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html