netdev - Re: bridge: fix use-after-free in br_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080703.035408.214725711.davem@davemloft.net>
Date:	Thu, 03 Jul 2008 03:54:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org
Subject: Re: bridge: fix use-after-free in br_cleanup_bridges()

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 2 Jul 2008 09:48:17 -0700

> On Wed, 02 Jul 2008 15:04:14 +0200
> Patrick McHardy <kaber@...sh.net> wrote:
> 
> > commit 96f1dd78dad10d61bdd487edadea6adda5425e4c
> > Author: Patrick McHardy <kaber@...sh.net>
> > Date:   Wed Jul 2 15:02:23 2008 +0200
> > 
> >     bridge: fix use-after-free in br_cleanup_bridges()
> > 
> >     Unregistering a bridge device may cause virtual devices stacked on the
> >     bridge, like vlan or macvlan devices, to be unregistered as well.
> >     br_cleanup_bridges() uses for_each_netdev_safe() to iterate over all
> >     devices during cleanup. This is not enough however, if one of the
> >     additionally unregistered devices is next in the list to the bridge
> >     device, it will get freed as well and the iteration continues on
> >     the freed element.
> > 
> >     Restart iteration after each bridge device removal from the beginning to
> >     fix this, similar to what rtnl_link_unregister() does.
> > 
> >     Signed-off-by: Patrick McHardy <kaber@...sh.net>
> 
> Acked-by: Stephen Hemminger <shemminger@...tta.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html