netdev - Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080706104130.8044ec03.randy.dunlap@oracle.com>
Date:	Sun, 6 Jul 2008 10:41:30 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Bill Fink <billfink@...dspring.com>
Cc:	"Subbu Seetharaman" <subbus@...verengines.com>, jeff@...zik.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

On Sat, 5 Jul 2008 01:39:33 -0400 Bill Fink wrote:

> On Fri, 04 Jul 2008, Subbu Seetharaman wrote:
> 
> > Signed-off-by: Subbu Seetharaman <subbus@...verengines.com>
> > ---
> >  MAINTAINERS          |    7 +++++++
> >  drivers/net/Kconfig  |    8 ++++++++
> >  drivers/net/Makefile |    1 +
> >  3 files changed, 16 insertions(+), 0 deletions(-)
> 
> ...
> 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index f4182cf..78b4d6e 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2581,6 +2581,14 @@ config BNX2X
> >  
> >  source "drivers/net/sfc/Kconfig"
> >  
> > +config BENET
> > +	tristate "ServerEngines 10Gb NIC - BladeEngine"
> > +	depends on PCI
> > +	select INET_LRO
> > +	help
> > +	  This driver implements the NIC functionality for ServerEngines
> > +	  10Gb network adapter BladeEngine (EC 3210).
> > +
> >  endif # NETDEV_10000
> >  
> >  source "drivers/net/tokenring/Kconfig"
> 
> I'm no Kconfig expert, but based on previous driver discussions,
> I believe the above depends needs to be changed to:
> 
> 	depends on PCI && INET
> 
> to prevent certain build problems that can arise from having just
> the "select INET_LRO" clause.

Correct.  Thanks for catching that.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html