commit 7aaf76390d820383eb4069065ec2e1b5ee479ef9
Author: Patrick McHardy <kaber@trash.net>
Date:   Mon Jul 7 00:21:09 2008 +0200

    net: fix dev_set_promiscuity() breakage
    
    Commit dad9b335 (netdevice: Fix promiscuity and allmulti overflow) broke
    dev_set_promiscuity() by returning on success without reprogramming the
    device.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>

diff --git a/net/core/dev.c b/net/core/dev.c
index bfa9a6a..7593393 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2859,7 +2859,7 @@ int dev_set_promiscuity(struct net_device *dev, int inc)
 	int err;
 
 	err = __dev_set_promiscuity(dev, inc);
-	if (!err)
+	if (err < 0)
 		return err;
 	if (dev->flags != old_flags)
 		dev_set_rx_mode(dev);