netdev - Re: [NET-NEXT PATCH 08/18] igb: Introduce multiple TX queues with infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080705.211400.95116379.davem@davemloft.net>
Date:	Sat, 05 Jul 2008 21:14:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [NET-NEXT PATCH 08/18] igb: Introduce multiple TX queues with
 infrastructure

From: Jeff Garzik <jeff@...zik.org>
Date: Fri, 04 Jul 2008 08:43:10 -0400

> Jeff Kirsher wrote:
> > From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> > 
> > This code adds multiple Tx queue infrastructure much like we
> > previously did in ixgbe. The MSI-X vector mapping is the bulk of
> > the change.
> > 
> > IAM can now be safely enabled and we've verified that it does
> > work correctly. We can also eliminate the tx ring lock.
> > 
> > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> > Signed-off-by: Mitch Williams <mitch.a.williams@...el.com>
> > Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> > ---
> > 
> >  drivers/net/igb/igb.h      |    6 +-
> >  drivers/net/igb/igb_main.c |  160 ++++++++++++++++++++++++++++++--------------
> >  2 files changed, 113 insertions(+), 53 deletions(-)
> 
> presumably this should wait for david to finish his multi-TX stuff?

Adding infrastructure now is a good thing.  I did something similar
for NIU, and the Broadcom folks have done similar for bnx2*.

That's why the NIU multiqueue TX patch in my series was only 10 lines
of changes, all the infrastructure and init was in the driver already :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html