netdev - Re: [Oops] fib_trie with ip route add throw since 2.6.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Jul 2008 21:25:59 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	William Boughton <bill@...ghton.de>, netdev@...r.kernel.org,
	stephen.hemminger@...tta.com
Subject: Re: [Oops] fib_trie with ip route add throw since 2.6.25

Stephen Hemminger wrote:
[...]
> Agreed, a little more explanation would be good
>    * return values?? fn_trie_lookup is same as fn_hash_lookup
>    * check_leaf use return value of fn_trie_lookup so it can warpout without conditional
>    * this needs some comments.

It does, doesn't it?  I still don't know what the return values mean, but
when William found this I stared at the diff and looked at the callers
until I spotted what the functional change was. :-)

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html