netdev - Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Jul 2008 23:15:48 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
CC:	Nicolas Pitre <nico@....org>,
	Dale Farnsworth <dale@...nsworth.org>,
	Ashish Karkare <akarkare@...vell.com>,
	Jesper Dangaard Brouer <jdb@...x.dk>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan
 tag by hand

Lennert Buytenhek wrote:
> On Mon, Jul 07, 2008 at 11:01:18PM +0200, Patrick McHardy wrote:
> 
>>> When inserting a vlan tag into an skb by hand (in the case the
>>> target network device hardware does not support inserting a vlan
>>> tag by passing it in via the TX descriptor), making a copy of the
>>> skb to be modified by calling skb_copy() is overkill, since
>>> skb_copy() will needlessly linearize the skb, copying of all of
>>> the fragmented data around, and checksumming the paket in software
>>> even if the hardware is perfectly capable of doing that by itself.
>>>
>>> For this case, pskb_copy() does exactly what is needed and no more,
>>> so use that instead.
>>>
>>> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
>> This looks fine to me.
> 
> OK.  Since the mv643xx_eth patch (2/2) depends on both this patch
> and the one you/I sent previously, could you merge the mv643xx_eth
> patch (2/2) via your tree as well?


I already sent the network_header fix to Dave, so its probably
easiest to have it go through him directly. Your patch applies
cleanly on top of my VLAN update from this morning.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html