[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 07 Jul 2008 16:14:31 -0700
From: Roland Dreier <rdreier@...co.com>
To: David Miller <davem@...emloft.net>
Cc: shemminger@...tta.com, arjan@...radead.org, netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message
> I doubt it uses the RTNL semaphore elsewhere to protect
> against this path, which is the only protection these
> calls currently have.
As far as I can tell from reading the code, the only places in cxgb3
that use t3_read_flash() are in the netdevice's open and ioctl methods,
and the ethtool get_drvinfo method. So as far as I can tell the current
code is fine as long as rtnl is held across get_drvinfo.
> Please don't bring up scarecrows, this looks like simply
> a bug which already exists.
I don't even know how to take this. "Please don't review our changes"??
"Please don't report bugs"??
- R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists