[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 07 Jul 2008 01:43:06 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: "Denis V. Lunev" <den@...nvz.org>
Cc: davem@...emloft.net, containers@...ts.osdl.org,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/9] ipv4: remove static flush_delay variable
"Denis V. Lunev" <den@...nvz.org> writes:
> flush delay is used as an external storage for net.ipv4.route.flush sysctl
> entry. It is write-only.
>
> The ctl_table->data for this entry is used once. Fix this case to point
> to the stack to remove global variable. Do this to avoid additional
> variable on struct net in the next patch.
>
> Possible race (as it was before) accessing this local variable is removed
> using flush_mutex.
FYI. You can avoid the locking entirely by defining a local struct ctl_table variable
on the stack.
Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists