netdev - Re: Printing the driver name as part of the netdev watchdog message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080706.182243.65603166.davem@davemloft.net>
Date:	Sun, 06 Jul 2008 18:22:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	arjan@...radead.org, netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message

From: Stephen Hemminger <shemminger@...tta.com>
Date: Sun, 6 Jul 2008 18:08:42 -0700

> For consistency each call through ethtool_ops should
> be holding rtnl mutex. And since dev_watchdog is a timer routine,
> it is not safe to acquire a mutex there.

I think "get driver info", which does nothing but copy strings out of
the driver software state, is a safe exception to these strict locking
rules.

Don't you think? :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html