[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 7 Jul 2008 17:52:18 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Patrick McHardy <kaber@...sh.net>
Cc: davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: vlan 03/07: Add ethtool support
Patrick McHardy wrote:
> vlan: Add ethtool support
>
> Add ethtool support for querying the device for offload settings.
>
> Signed-off-by: Patrick McHardy <kaber@...sh.net>
[...]
> +static u32 vlan_ethtool_get_rx_csum(struct net_device *dev)
> +{
> + const struct vlan_dev_info *vlan = vlan_dev_info(dev);
> + struct net_device *real_dev = vlan->real_dev;
> +
> + if (real_dev->ethtool_ops == NULL ||
> + real_dev->ethtool_ops->get_rx_csum == NULL)
> + return 0;
> + return real_dev->ethtool_ops->get_rx_csum(real_dev);
But we don't know whether RX checksum offload applies to VLAN-tagged
packets (or, admittedly, any specific protocol). It would be nice if there
was a feature flag for this so it could be advertised in vlan_features.
> +}
> +
> +static const struct ethtool_ops vlan_ethtool_ops = {
> + .get_link = ethtool_op_get_link,
> + .get_rx_csum = vlan_ethtool_get_rx_csum,
Can't we also add:
.get_tx_csum = ethtool_op_get_tx_csum,
.get_sg = ethtool_op_get_sg,
.get_tso = ethtool_op_get_tso,
.get_flags = ethtool_op_get_flags,
?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists