netdev - Re: Printing the driver name as part of the netdev watchdog message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080707100556.6a3dd3d7@extreme>
Date:	Mon, 7 Jul 2008 10:05:56 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	David Miller <davem@...emloft.net>, arjan@...radead.org,
	netdev@...r.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message

On Sun, 06 Jul 2008 21:53:24 -0400
Jeff Garzik <jeff@...zik.org> wrote:

> David Miller wrote:
> > From: Stephen Hemminger <shemminger@...tta.com>
> > Date: Sun, 6 Jul 2008 18:08:42 -0700
> > 
> >> For consistency each call through ethtool_ops should
> >> be holding rtnl mutex. And since dev_watchdog is a timer routine,
> >> it is not safe to acquire a mutex there.
> > 
> > I think "get driver info", which does nothing but copy strings out of
> > the driver software state, is a safe exception to these strict locking
> > rules.
> > 
> > Don't you think? :-)
> 
> Indeed...
> 

It is save exception, but documentation needed?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html